Skip to content

add pad transforms with unit tests for lazy resampling#6031

Merged
wyli merged 31 commits intoProject-MONAI:devfrom
KumoLiu:croppad-lazy
Feb 24, 2023
Merged

add pad transforms with unit tests for lazy resampling#6031
wyli merged 31 commits intoProject-MONAI:devfrom
KumoLiu:croppad-lazy

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Feb 21, 2023 •
edited
Loading

Part of #5991.

Description

This PR adds the pad transforms from #5860 relate to lazy resampling, and it belongs to the second part mentioned in #5991

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu and others added 14 commits February 18, 2023 16:30
@KumoLiu
first commit
6aae1c2 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
Merge branch 'dev' into croppad-lazy
12042f0
@KumoLiu
Merge branch 'dev' into croppad-lazy
cc9ac44
@KumoLiu
add spatialpad unittest
23bf60f 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
Merge remote-tracking branch 'origin/dev' into croppad-lazy
1816a9a
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
34692f5 
for more information, see https://pre-commit.ci
@KumoLiu
minor fix
67e6917 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
add spatialpadd unit tests
da894ae 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
add lazy support in Padd
54573f4 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
add pad_test_pending_ops in padder
16ac8cd 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
add pad unittests
fda15c4 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
rm update_meta in ResampleToMatch
4ba29b7 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
modify test_spatial_resample
4213bf9 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
modify test_spatial_resampled
620fab4 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu changed the title [WIP] add crop and pad transforms with unit tests for lazy resampling [WIP] add pad transforms with unit tests for lazy resampling Feb 22, 2023
@KumoLiu KumoLiu marked this pull request as ready for review February 22, 2023 14:58
@KumoLiu KumoLiu changed the title [WIP] add pad transforms with unit tests for lazy resampling add pad transforms with unit tests for lazy resampling Feb 22, 2023
wyli
wyli reviewed Feb 22, 2023
View reviewed changes
@KumoLiu
remove '_' in pad_nd
f5e88d0 
Signed-off-by: KumoLiu <[email protected]>
wyli
wyli reviewed Feb 22, 2023
View reviewed changes
Nic-Ma
Nic-Ma reviewed Feb 23, 2023
View reviewed changes
Nic-Ma
Nic-Ma reviewed Feb 23, 2023
View reviewed changes
wyli
wyli reviewed Feb 23, 2023
View reviewed changes
yiheng-wang-nv
yiheng-wang-nv reviewed Feb 23, 2023
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Feb 24, 2023

/build

Nic-Ma
Nic-Ma reviewed Feb 24, 2023
View reviewed changes
Nic-Ma
Nic-Ma reviewed Feb 24, 2023
View reviewed changes
Nic-Ma
Nic-Ma reviewed Feb 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some minor comments inline, others look good to me.

Thanks.

Nic-Ma
Nic-Ma approved these changes Feb 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
Looks good to me now.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Feb 24, 2023

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) February 24, 2023 10:15
@wyli wyli disabled auto-merge February 24, 2023 11:53
@wyli wyli enabled auto-merge (squash) February 24, 2023 11:53
@wyli wyli merged commit 69d807a into Project-MONAI:dev Feb 24, 2023
wyli
wyli reviewed Feb 26, 2023
View reviewed changes
@KumoLiu KumoLiu deleted the croppad-lazy branch February 27, 2023 04:54
@wyli wyli mentioned this pull request Feb 28, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv left review comments

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KumoLiu @wyli @Nic-Ma @yiheng-wang-nv