transforms to have multi-sample trait#6003
Merged
wyli merged 3 commits intoProject-MONAI:devfrom Feb 15, 2023
Merged
Conversation
Signed-off-by: Wenqi Li <[email protected]>
wyli
requested review from
KumoLiu,
Nic-Ma,
SachidanandAlle,
atbenmurray,
ericspod and
yiheng-wang-nv
Nic-Ma
approved these changes
Feb 15, 2023
Contributor
|
Looks good to me. |
Contributor
|
I'd like to make a suggestion that the traits come out of transform.py and into a separate file traits.py. This reduces the potential of cyclic dependencies when adding / refactoring functionality around transforms. |
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
atbenmurray
approved these changes
Feb 15, 2023
SachidanandAlle
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6002
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.