Disallow incomplete defs in optimizers module#5928
Merged
wyli merged 1 commit intoProject-MONAI:devfrom Feb 1, 2023
Merged
Conversation
Signed-off-by: Felix Schnabel <[email protected]>
f-schnabel
force-pushed
the
feature/disallow_incomplete_defs_optimizers
branch
from
1d0d77a to
aa5964a
Compare
wyli
approved these changes
Feb 1, 2023
Contributor
|
/build |
wyli
pushed a commit
to wyli/MONAI
that referenced
this pull request
Feb 2, 2023
Part of Project-MONAI#5884. ### Description Fully type annotate any functions with at least one type annotation in module `optimizers`. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. Signed-off-by: Felix Schnabel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5884.
Description
Fully type annotate any functions with at least one type annotation in module
optimizers.Types of changes
./runtests.sh --quick --unittests --disttests.