Skip to content

Patch inference#5914

Merged
Nic-Ma merged 72 commits intoProject-MONAI:devfrom
bhashemian:patch-inference
Feb 22, 2023
Merged

Patch inference#5914
Nic-Ma merged 72 commits intoProject-MONAI:devfrom
bhashemian:patch-inference

Conversation

@bhashemian
Copy link
Copy Markdown
Member

@bhashemian bhashemian commented Jan 30, 2023

Fixes #5864 #5871 #5872

Description

This PR implements PatchInferer according to #5837, the base classes for Splitter and Merger along with few concrete classes SlidingWindowSplitter and AvgMerger. This can provide a sliding window inference for tensor inputs.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Feb 17, 2023

@KumoLiu @Nic-Ma @ericspod, I tried to address all your comments. Please let me know if I have missed anything or if you have any other comments. Thanks

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update. I put some minor comments inline, it overall looks good to me.

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the quick update.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Feb 22, 2023

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) February 22, 2023 03:36
@Nic-Ma Nic-Ma merged commit f1bc378 into Project-MONAI:dev Feb 22, 2023
@bhashemian bhashemian deleted the patch-inference branch February 22, 2023 12:08
@bhashemian bhashemian linked an issue Feb 27, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement an average Merger for overlapping patches Implement a Splitter for sliding window Implement PatchInferer, Splitter, Merger

4 participants