make path user expansion optional#5892
Merged
wyli merged 2 commits intoProject-MONAI:devfrom Jan 24, 2023
Merged
Conversation
Contributor
|
Thanks, could you please amend the commit message to have a sign-off line "git commit --amend --sign-off"? See https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work or please follow this dco suggestion https://github.com/Project-MONAI/MONAI/pull/5892/checks?check_run_id=10839784668 |
Signed-off-by: Guilherme Pires <[email protected]>
colobas
force-pushed
the
feature/optional_expanduser
branch
from
e142bdc to
9de21dc
Compare
Contributor
Author
|
signed off! |
wyli
approved these changes
Jan 24, 2023
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
LoadImage, file paths get wrapped withpathlib.Pathand.expanduser()is called. This causes paths with a protocol prefix to get corrupted (e.g. in my case paths starting withs3://are getting one of the forward slashes removed)This PR makes the wrapping with
Pathand call to.expanduser()optional (but set toTrueby default, to preserve current behavior)Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.