Complete partially typed signatures (monai.utils)#5891
Merged
wyli merged 5 commits intoProject-MONAI:devfrom Jan 23, 2023
Merged
Complete partially typed signatures (monai.utils)#5891wyli merged 5 commits intoProject-MONAI:devfrom
wyli merged 5 commits intoProject-MONAI:devfrom
Conversation
Contributor
Author
|
CI failed, because python Literals were introduced in 3.8, but I'm using them inside the code. |
f-schnabel
commented
Jan 23, 2023
f-schnabel
force-pushed
the
feature/disallow_incomplete_defs_utils
branch
from
4d3f956 to
43ecc34
Compare
Signed-off-by: Felix Schnabel <[email protected]>
Signed-off-by: Felix Schnabel <[email protected]>
Signed-off-by: Felix Schnabel <[email protected]>
Signed-off-by: Felix Schnabel <[email protected]>
f-schnabel
force-pushed
the
feature/disallow_incomplete_defs_utils
branch
from
076881d to
a3e70e6
Compare
…omplete_defs_utils Signed-off-by: Wenqi Li <[email protected]>
wyli
reviewed
Jan 23, 2023
Contributor
|
/build |
wyli
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5884.
Description
Fully type annotate any functions with at least one type annotation in
module
visualizeTypes of changes
./runtests.sh --quick --unittests --disttests.