Disallow incomplete defs in visualize module#5885
Merged
wyli merged 1 commit intoProject-MONAI:devfrom Jan 23, 2023
Merged
Conversation
Signed-off-by: Felix Schnabel <[email protected]>
f-schnabel
force-pushed
the
feature_disallow_incomplete_defs
branch
from
17a31ab to
580772c
Compare
wyli
approved these changes
Jan 23, 2023
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5884.
Description
Fully type annotate any functions with at least one type annotation in module
visualize.Types of changes
./runtests.sh --quick --unittests --disttests.