5869 adds support of _mode_ keyword in instantiate#5880
Merged
wyli merged 4 commits intoProject-MONAI:devfrom Jan 23, 2023
Merged
5869 adds support of _mode_ keyword in instantiate#5880wyli merged 4 commits intoProject-MONAI:devfrom
_mode_ keyword in instantiate#5880wyli merged 4 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
a24d05a to
2903717
Compare
_mode_ keyword in instantiate_mode_ keyword in instantiate
Nic-Ma
approved these changes
Jan 23, 2023
Contributor
Nic-Ma
left a comment
There was a problem hiding this comment.
This PR slightly changed the default behavior of ConfigComponent for functions, but I think it's acceptable because now it's same as Hydra and other similar projects:
https://github.com/facebookresearch/hydra/blob/main/hydra/_internal/instantiate/_instantiate2.py#L283
Thanks.
…le-inst Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #5869
Description
support an optional
_mode_in"default"/"partial"/"debug"when callingcomponent(**kwargs)example config:
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.