Skip to content

5833 fixes Nifti1Image test cases#5834

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:5833-fixes-tests
Jan 10, 2023
Merged

5833 fixes Nifti1Image test cases#5834
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:5833-fixes-tests

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jan 9, 2023

Fixes #5833

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits January 9, 2023 21:03
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jan 9, 2023

/build

@wyli wyli marked this pull request as ready for review January 9, 2023 22:04
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wyli ,

Do we also have the same issue in tutorials?

Thanks.

@wyli wyli merged commit 6060a47 into Project-MONAI:dev Jan 10, 2023
@wyli wyli deleted the 5833-fixes-tests branch January 10, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compatibility with nibabel 5.0

2 participants