MyPy disallow untyped decorators#5824
Merged
wyli merged 9 commits intoProject-MONAI:devfrom Jan 9, 2023
Merged
Conversation
Signed-off-by: Felix Schnabel <[email protected]>
Signed-off-by: Felix Schnabel <[email protected]>
Signed-off-by: Felix Schnabel <[email protected]> Update docstrings. Signed-off-by: Felix Schnabel <[email protected]>
Signed-off-by: Felix Schnabel <[email protected]> Revert Workflow. Signed-off-by: Felix Schnabel <[email protected]>
…s of IgniteMetric. Signed-off-by: Felix Schnabel <[email protected]>
Signed-off-by: Felix Schnabel <[email protected]>
Signed-off-by: Felix Schnabel <[email protected]>
Signed-off-by: Felix Schnabel <[email protected]>
Contributor
|
/build |
wyli
approved these changes
Jan 9, 2023
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5823.
Description
This PR types following decorators:
deprecateddeprecated_argdeprecated_arg_defaultFound here.
It also fixes any typing issues that occurred because of the additional typing.
Secondly, it fixes untyped decorator usage of the
ignitelibrary (because ofoptional_import) for Workflow and IgniteMetric.Types of changes
./runtests.sh --quick --unittests --disttests.