Skip to content

5793 Avoid using sphinx 6.0.0#5794

Merged
wyli merged 10 commits intoProject-MONAI:devfrom
yiheng-wang-nv:5793-sphinx-error
Jan 4, 2023
Merged

5793 Avoid using sphinx 6.0.0#5794
wyli merged 10 commits intoProject-MONAI:devfrom
yiheng-wang-nv:5793-sphinx-error

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

Fixes #5793 .

Description

This PR is used to avoid using incompatible sphinx 6.0.0
Originally I followed their changelog (https://www.sphinx-doc.org/en/master/changes.html#id4) and try to fix the issue, but I met sphinxcontrib.jquery not found error after the changes. I'm not sure if there are anything wrong with my changes, thus I decided to submit this PR to temporarily use sphinx 5.3.0, and we can add a new ticket for further changes after this PR is merged.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv yiheng-wang-nv requested a review from wyli December 30, 2022 08:03
@yiheng-wang-nv
Copy link
Copy Markdown
Contributor Author

yiheng-wang-nv commented Dec 30, 2022

To avoid extra time used in trying sphinx changelog, let me submit a new commit that contains the steps I following.

As we can see from:
https://github.com/Project-MONAI/MONAI/actions/runs/3805665538/jobs/6473790720#step:7:182
module not found error happened.

@wyli wyli mentioned this pull request Jan 4, 2023
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 4, 2023

/build

@wyli wyli enabled auto-merge (squash) January 4, 2023 10:32
@wyli wyli merged commit e3d1cc8 into Project-MONAI:dev Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build-docs workflow failed

2 participants