Skip to content

'dimensions' -> 'spatial_dims'#5792

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
andre-fs-ferreira:patch-1
Jan 4, 2023
Merged

'dimensions' -> 'spatial_dims'#5792
wyli merged 4 commits intoProject-MONAI:devfrom
andre-fs-ferreira:patch-1

Conversation

@andre-fs-ferreira
Copy link
Copy Markdown
Contributor

@andre-fs-ferreira andre-fs-ferreira commented Dec 28, 2022

VarAutoEncoder.init() got an unexpected keyword argument 'dimensions' because now it is called spatial_dims.

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Dec 29, 2022

Hi @ShadowTwin41 ,

Please add deprecated_arg for the change, refer to:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/apps/deepgrow/transforms.py#L496

Thanks.

@andre-fs-ferreira
Copy link
Copy Markdown
Contributor Author

andre-fs-ferreira commented Dec 29, 2022

Hi @Nic-Ma
Thank you! I hope I have done it right.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Dec 29, 2022

Hi @Nic-Ma Thank you! I hope I have done it right.

Hi @ShadowTwin41 ,

Sorry I misunderstood your PR, I thought you changed the source code, actually you changed the doc-string.
Then no need to add the deprecated_arg, please remove it..

Thanks.

@KumoLiu
Copy link
Copy Markdown
Contributor

KumoLiu commented Dec 30, 2022

Hi @ShadowTwin41, could you please help fix the CI error, once it is finished, this PR can be merged.
Thanks!

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Dec 30, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Dec 30, 2022

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) December 30, 2022 03:02
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 4, 2023

/build

andre-fs-ferreira and others added 4 commits January 4, 2023 12:28
@andre-fs-ferreira @wyli
'dimensions' -> 'spatial_dims'
cb1c059 
VarAutoEncoder.__init__() got an unexpected keyword argument 'dimensions' because now it is called spatial_dims.
@andre-fs-ferreira @wyli
Update varautoencoder.py
e7773ff
@andre-fs-ferreira @wyli
Update varautoencoder.py
42278a7
@monai-bot @wyli
[MONAI] code formatting
8f8fa29 
Signed-off-by: monai-bot <[email protected]>
@wyli wyli disabled auto-merge January 4, 2023 12:29
@wyli wyli enabled auto-merge (squash) January 4, 2023 12:30
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jan 4, 2023

/build

@wyli wyli merged commit 4381e4b into Project-MONAI:dev Jan 4, 2023
wyli pushed a commit that referenced this pull request Jan 4, 2023
@andre-fs-ferreira @wyli
'dimensions' -> 'spatial_dims' (#5792)
936b88d 
VarAutoEncoder.__init__() got an unexpected keyword argument
'dimensions' because now it is called spatial_dims.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andre-fs-ferreira @Nic-Ma @KumoLiu @wyli @monai-bot