Skip to content

Revert "Add ValueError in GenerateSuccinctContour (#5719)"#5737

Merged
wyli merged 1 commit intodevfrom
revert-5719-generatesuccinctcontour
Dec 14, 2022
Merged

Revert "Add ValueError in GenerateSuccinctContour (#5719)"#5737
wyli merged 1 commit intodevfrom
revert-5719-generatesuccinctcontour

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Dec 14, 2022

This reverts commit 2b160b3.

Fixes #5719 (comment)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested a review from KumoLiu December 14, 2022 12:00
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Dec 14, 2022

/build

@wyli wyli enabled auto-merge (squash) December 14, 2022 12:20
@wyli wyli merged commit ae89327 into dev Dec 14, 2022
@wyli wyli deleted the revert-5719-generatesuccinctcontour branch December 15, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants