Skip to content

Enable auto3dseg maximize gpu utils#5733

Merged
wyli merged 132 commits intoProject-MONAI:devfrom
dongyang0122:auto3dseg_maximize_gpu_utils
Dec 15, 2022
Merged

Enable auto3dseg maximize gpu utils#5733
wyli merged 132 commits intoProject-MONAI:devfrom
dongyang0122:auto3dseg_maximize_gpu_utils

Conversation

@dongyang0122
Copy link
Copy Markdown
Collaborator

@dongyang0122 dongyang0122 commented Dec 14, 2022 •
edited
Loading

Description

Enable auto3dseg maximize gpu utilization based on gpus in higher API levels.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Dong Yang and others added 30 commits August 8, 2022 20:09
init dir
d8ff646 
Signed-off-by: Dong Yang <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1093cb0 
for more information, see https://pre-commit.ci
remove doc
b7c4e0f 
Signed-off-by: dongy <[email protected]>
update repo
7bf4fdb 
Signed-off-by: dongy <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
b9b4af5 
for more information, see https://pre-commit.ci
update repo
7dca898 
Signed-off-by: Dong Yang <[email protected]>
update repo
753b3ba 
Signed-off-by: Dong Yang <[email protected]>
update repo
3fce929 
Signed-off-by: Dong Yang <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2a3f52f 
for more information, see https://pre-commit.ci
update repo
d51b08e 
Signed-off-by: Dong Yang <[email protected]>
update repo
657262f 
Signed-off-by: Dong Yang <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cb77f67 
for more information, see https://pre-commit.ci
update repo
34342f4 
Signed-off-by: Dong Yang <[email protected]>
Merge branch 'dev' of https://github.com/dongyang0122/MONAI into dev
fad84ba
update repo
8ec2547 
Signed-off-by: Dong Yang <[email protected]>
update repo
d12a7be 
Signed-off-by: Dong Yang <[email protected]>
update repo
73428e3 
Signed-off-by: Dong Yang <[email protected]>
update repo
0b91953 
Signed-off-by: Dong Yang <[email protected]>
update repo
76e0b5e 
Signed-off-by: Dong Yang <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6f97afe 
for more information, see https://pre-commit.ci
update repo
e0f6d8c 
Signed-off-by: Dong Yang <[email protected]>
update repo
2fa8ba3 
Signed-off-by: Dong Yang <[email protected]>
update repo
004b4f1 
Signed-off-by: Dong Yang <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
dde1e6d 
for more information, see https://pre-commit.ci
update repo
8409e94 
Signed-off-by: Dong Yang <[email protected]>
Merge branch 'dev' of https://github.com/dongyang0122/MONAI into dev
ea6a085
update repo
30d50d3 
Signed-off-by: Dong Yang <[email protected]>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
dbdbc98 
for more information, see https://pre-commit.ci
update repo
fa34745 
Signed-off-by: Dong Yang <[email protected]>
Merge branch 'dev' of https://github.com/dongyang0122/MONAI into dev
c131590
@mingxin-zheng
Copy link
Copy Markdown
Contributor

mingxin-zheng commented Dec 14, 2022 •
edited
Loading

One thing to note is this feature is not available on the SegResNet algorithm template. If it is not difficult to add, should be consider adding the support of SegResNet too? @dongyang0122 @myron

Also, @dongyang0122 I made some minor comments
#5733 (comment)
#5733 (comment)

None of those comments is critical and feel free to pass them. If you are updating the PR, it would be nice to consider those changes.

wyli
wyli reviewed Dec 14, 2022
View reviewed changes
wyli
wyli reviewed Dec 14, 2022
View reviewed changes
@mingxin-zheng mingxin-zheng mentioned this pull request Dec 14, 2022
Merged
7 tasks
dongy added 3 commits December 14, 2022 11:43
update changes
0f64121 
Signed-off-by: dongy <[email protected]>
update changes
e1df079 
Signed-off-by: dongy <[email protected]>
update changes
4a5e58e 
Signed-off-by: dongy <[email protected]>
mingxin-zheng
mingxin-zheng reviewed Dec 15, 2022
View reviewed changes
update changes
08b5e36 
Signed-off-by: dongy <[email protected]>
mingxin-zheng
mingxin-zheng reviewed Dec 15, 2022
View reviewed changes
@mingxin-zheng
Copy link
Copy Markdown
Contributor

mingxin-zheng commented Dec 15, 2022

@wyli I saw the following unrelated error. It seems some downloading fails in other unit tests

======================================================================
ERROR: test_grad (tests.test_warp.TestWarp)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/MONAI/MONAI/tests/test_warp.py", line 102, in setUp
    download_url_or_skip_test(
  File "/home/runner/work/MONAI/MONAI/tests/utils.py", line 731, in download_url_or_skip_test
    download_url(*args, **kwargs)
  File "/home/runner/work/MONAI/MONAI/monai/apps/utils.py", line 203, in download_url
    _download_with_progress(url, tmp_name, progress=progress)
  File "/home/runner/work/MONAI/MONAI/monai/apps/utils.py", line 114, in _download_with_progress
    raise e
  File "/home/runner/work/MONAI/MONAI/monai/apps/utils.py", line 111, in _download_with_progress
    urlretrieve(url, filepath)
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 247, in urlretrieve
    with contextlib.closing(urlopen(url, data)) as fp:
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 640, in http_response
    response = self.parent.error(
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 563, in error
    result = self._call_chain(*args)
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 755, in http_error_302
    return self.parent.open(new, timeout=req.timeout)
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 640, in http_response
    response = self.parent.error(
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 569, in error
    return self._call_chain(*args)
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.

dongy added 2 commits December 14, 2022 19:28
update changes
df738be 
Signed-off-by: dongy <[email protected]>
update changes
d9a2887 
Signed-off-by: dongy <[email protected]>
mingxin-zheng
mingxin-zheng reviewed Dec 15, 2022
View reviewed changes
dongy added 3 commits December 14, 2022 19:46
update changes
798ef2d 
Signed-off-by: dongy <[email protected]>
update changes
bacf27e 
Signed-off-by: dongy <[email protected]>
update changes
a74fe06 
Signed-off-by: dongy <[email protected]>
mingxin-zheng
mingxin-zheng reviewed Dec 15, 2022
View reviewed changes
dongy added 3 commits December 14, 2022 21:10
update changes
4b6e118 
Signed-off-by: dongy <[email protected]>
update changes
31d1854 
Signed-off-by: dongy <[email protected]>
update changes
85fe78b 
Signed-off-by: dongy <[email protected]>
mingxin-zheng
mingxin-zheng reviewed Dec 15, 2022
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Dec 15, 2022

/build

@wyli wyli enabled auto-merge (squash) December 15, 2022 11:16
@wyli wyli merged commit e989dc7 into Project-MONAI:dev Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli left review comments

@mingxin-zheng mingxin-zheng mingxin-zheng approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

@dongyang0122 dongyang0122

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dongyang0122 @mingxin-zheng @wyli