Skip to content

Change default dtype value in Watershed and GenerateWatershedMarkers#5732

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
KumoLiu:dtype-in-marker
Dec 14, 2022
Merged

Change default dtype value in Watershed and GenerateWatershedMarkers#5732
wyli merged 4 commits intoProject-MONAI:devfrom
KumoLiu:dtype-in-marker

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Dec 14, 2022

Fixes #.

Description

  • When the image is large, the number of instances may exceed np.uint8, so the default dtype should set to np.int64
  • a workaround way to add FillHoles before generate_instance_contour, may prevent the issue when instances contain hole

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu marked this pull request as ready for review December 14, 2022 10:10
@KumoLiu KumoLiu requested review from bhashemian and wyli December 14, 2022 14:06
Copy link
Copy Markdown
Member

@bhashemian bhashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Dec 14, 2022

/build

@wyli wyli enabled auto-merge (squash) December 14, 2022 14:15
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Dec 14, 2022

/build

@wyli wyli merged commit c10cdd2 into Project-MONAI:dev Dec 14, 2022
@KumoLiu KumoLiu deleted the dtype-in-marker branch December 15, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants