Resolves non-gradient bug of SSIM Loss#5686
Merged
wyli merged 15 commits intoProject-MONAI:devfrom Dec 9, 2022
Merged
Conversation
…te unit test to cover changes Signed-off-by: PedroFerreiradaCosta <[email protected]>
Signed-off-by: PedroFerreiradaCosta <[email protected]>
Signed-off-by: PedroFerreiradaCosta <[email protected]>
…struct _compute_metric superclass dependency Signed-off-by: PedroFerreiradaCosta <[email protected]>
Signed-off-by: PedroFerreiradaCosta <[email protected]>
Signed-off-by: PedroFerreiradaCosta <[email protected]>
Signed-off-by: PedroFerreiradaCosta <[email protected]>
Signed-off-by: PedroFerreiradaCosta <[email protected]>
Signed-off-by: PedroFerreiradaCosta <[email protected]>
Signed-off-by: PedroFerreiradaCosta <[email protected]>
Contributor
|
thanks, could you please add a unit test |
Contributor
|
could you please help test these changes in a training pipeline? @Can-Zhao @mersad95zd |
Signed-off-by: PedroFerreiradaCosta <[email protected]>
Contributor
Author
|
@wyli submitted now a unit test in test_ssim_loss.py for checking if |
Contributor
|
/build |
wyli
approved these changes
Dec 8, 2022
Contributor
wyli
left a comment
There was a problem hiding this comment.
premerge tests work fine as well
Contributor
|
merging this for now, please feel free to follow up if you have further code changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5668 .
Description
The SSIM loss wasn't feeding into autograd - it wasn't allowing gradient to be calculated. Now they can be calculated.
As per my previous PR (#5550), the loss function is now calculated using the SSIMMetric (and not the other way around). The SSIMMetric in inheriting from class
IterationMetricthat runs.detach()on all inputs before running._compute_tensor().MONAI/monai/metrics/metric.py
Line 70 in 0737a33
I'm now calling the
SSIMMetric()._compute_tensor()explicitly, removing the step where it detaches from the current graph.To Reproduce
Expected behavior
loss.requires_gradwill now be True.Types of changes