I'm a bit confused by the auto fix by pre-commit.ci. I thought that type unions with A | B syntax was only added in python 3.10 but MONAI is targeting versions >= 3.7.
See also here: https://docs.python.org/3/library/typing.html#typing.Union

I'm a bit confused by the auto fix by pre-commit.ci. I thought that type unions with A | B syntax was only added in python 3.10 but MONAI is targeting versions >= 3.7. See also here: https://docs.python.org/3/library/typing.html#typing.Union

that particular file has from __future__ import annotations which triggers pyupgrade of pre-commit.ci to update the type annotations

Is it ok to add venv to the exclude path of black or should it be in another PR with an extra issue?
It was just quite annoying since my whole pc froze as black tried to format all dependencies, but I can remove it from this PR.

Is it ok to add venv to the exclude path of black or should it be in another PR with an extra issue? It was just quite annoying since my whole pc froze as black tried to format all dependencies, but I can remove it from this PR.

sure. could you please also avoid assert https://deepsource.io/gh/Project-MONAI/MONAI/run/66546629-66ba-4424-8758-2fe9f51ac2ed/python/BAN-B101?listindex=0 you can use isinstance to check the types

/build

/build

thanks @Shadow-Devil, I can see that the type annotation enhancements addressed a few potential bugs, that's great.

@wyli Thank you for apprechiating my work! I would like to go on and as my next type checking enhancement type the deprecated & deprecated_args decorators, since otherwise all functions annotated with them lose type information. Do you think this is a good next step? If yes, I will create an issue and work on it😄

thanks, I think those utilities will still need some refactoring (such as for #5653), type checking support could come later after that. But it's a good idea and please help create a feature request...