Merged
Conversation
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
approved these changes
Dec 5, 2022
Contributor
|
/build |
Contributor
|
Hi @rijobro , May I know why you changed the Thanks. |
Nic-Ma
reviewed
Dec 6, 2022
Contributor
|
/build |
auto-merge was automatically disabled
December 6, 2022 11:17
Base branch was modified
Contributor
|
/build |
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line
optional_import("cv2")causes the security light of my macOS to light up in green, even for the lowest level command e.g.,import monai. I was worried I had a virus until I realised what was causing it! To avoid worrying other users, I suggest we only import when a user is using theVideoDataset.also addresses #5660
Types of changes