Merged
Conversation
Signed-off-by: binliu <[email protected]>
…rue and modify the corresponding docstring Signed-off-by: binliu <[email protected]>
Nic-Ma
approved these changes
Dec 5, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me, please change the unit test.
Thanks.
…lose parameter in mlflow_handler can implement this function Signed-off-by: binliu <[email protected]>
Contributor
|
/build |
wyli
reviewed
Dec 5, 2022
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5649 .
Description
Add the
auto_closeparameter to mlflow_handler so that it can close the mlflow run according to given value.Update the default handler parameter, so that trainer and evaluator could have
Truevalue onauto_close.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.