revise cachedataset runtime_cache modes#5630
Merged
wyli merged 5 commits intoProject-MONAI:devfrom Dec 2, 2022
Merged
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
runtime_cache_input
branch
from
7f19b26 to
8503dfe
Compare
Nic-Ma
approved these changes
Dec 2, 2022
Contributor
|
The overall solution looks good to me and it matches the option 2 from @myron in #5615 (comment) Thanks. |
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
runtime_cache_input
branch
from
9cc7f1e to
15ccae8
Compare
Contributor
Author
|
/build |
Collaborator
|
This PR was created and merged without a discussion. Because it was done overnight, It started at 3am PST and merged at 10am PST, it did not give an opportunity for a review or a discussion. @wyli I don't believe it is a good project MONAI practice, you should have a meaningful discussion about it first. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5613
Description
runtime_cache=False: the default v1.0.1 behaviourruntime_cache=Trueor"thread": single process, for caching cuda tensorsruntime_cache="process": single process workflow + multiprocess dataloaderruntime_cache=user-provided object, could be used to pass a container shared among processesI feel in this way the user can determine what to use instead of guessing and providing an automated solution... let me know what you think @myron @Nic-Ma, I'm fine if this is eventually merged or not merged
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.