Width and height swapped when creating test image in data/synthetic/create_test_image_2d#5627
Merged
wyli merged 15 commits intoProject-MONAI:devfrom Dec 15, 2022
Conversation
Signed-off-by: OeslleLucena <[email protected]>
Signed-off-by: OeslleLucena <[email protected]>
…hen-creating-test-image-in-datasyntheticcreate_test_image_2d-1
Signed-off-by: OeslleLucena <[email protected]>
Signed-off-by: OeslleLucena <[email protected]>
…hen-creating-test-image-in-datasyntheticcreate_test_image_2d-1
Signed-off-by: OeslleLucena <[email protected]>
…in-datasyntheticcreate_test_image_2d-1' of https://github.com/OeslleLucena/MONAI into 5373-width-and-height-swapped-when-creating-test-image-in-datasyntheticcreate_test_image_2d-1
…hen-creating-test-image-in-datasyntheticcreate_test_image_2d-1
wyli
previously approved these changes
Dec 14, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
…est-image-in-datasyntheticcreate_test_image_2d-1
Contributor
|
/build |
wyli
reviewed
Dec 14, 2022
Signed-off-by: OeslleLucena <[email protected]>
…in-datasyntheticcreate_test_image_2d-1' of https://github.com/OeslleLucena/MONAI into 5373-width-and-height-swapped-when-creating-test-image-in-datasyntheticcreate_test_image_2d-1
…hen-creating-test-image-in-datasyntheticcreate_test_image_2d-1
…est-image-in-datasyntheticcreate_test_image_2d-1
Contributor
|
/build |
wyli
approved these changes
Dec 15, 2022
…est-image-in-datasyntheticcreate_test_image_2d-1
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: OeslleLucena [email protected]
Fixes #5373.
Description
Change the
synthetic.pyscript to have the (height, width, depth) format.Edit all the tests that uses
create_test_image_3dto match the new format.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.