Skip to content

5611 iter_patch no padding for 0/None patch size#5612

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:5611-iter-patch
Dec 1, 2022
Merged

5611 iter_patch no padding for 0/None patch size#5612
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:5611-iter-patch

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Nov 30, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #5611

Description

skip the padding to make smaller memory footprint when the patch size is 0 or None for a particular dimension

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits November 30, 2022 16:31
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma, ericspod and rijobro November 30, 2022 16:39
wyli added 4 commits November 30, 2022 16:59
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from KumoLiu and ericspod November 30, 2022 18:22
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Nov 30, 2022

maybe with this PR the GridPatch will require less mem or run faster, but it shouldn't change the outcome cc @KumoLiu

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Nov 30, 2022

/build

Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update, looks good to me!

@wyli wyli merged commit 4cf6cf8 into Project-MONAI:dev Dec 1, 2022
@wyli wyli deleted the 5611-iter-patch branch December 1, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iter_patch memory consumption

3 participants