Skip to content

Throw error with description when there are no valid user click/signals#5598

Merged
SachidanandAlle merged 1 commit intoProject-MONAI:devfrom
SachidanandAlle:nuclick
Nov 28, 2022
Merged

Throw error with description when there are no valid user click/signals#5598
SachidanandAlle merged 1 commit intoProject-MONAI:devfrom
SachidanandAlle:nuclick

Conversation

@SachidanandAlle
Copy link
Copy Markdown
Contributor

Signed-off-by: Sachidanand Alle [email protected]

Fixes # .
Throw error with description when there are no valid user click/signals

Description

Instead of torch.stack error, provide readable description when the signal is not valid, and no valid bounding boxes could be created based on user click points.

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@SachidanandAlle SachidanandAlle enabled auto-merge (squash) November 28, 2022 16:57
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 28, 2022

/build

@SachidanandAlle SachidanandAlle merged commit cc171a8 into Project-MONAI:dev Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 💯 Complete

Development

Successfully merging this pull request may close these issues.

2 participants