Enhance the handler ProbMapProducer to use FolderLayout#5570
Merged
wyli merged 5 commits intoProject-MONAI:devfrom Nov 23, 2022
Merged
Enhance the handler ProbMapProducer to use FolderLayout#5570wyli merged 5 commits intoProject-MONAI:devfrom
ProbMapProducer to use FolderLayout#5570wyli merged 5 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Behrooz <[email protected]>
wyli
approved these changes
Nov 23, 2022
Contributor
|
/build |
Contributor
|
thanks, I'm pushing the changes from #5576 here to unblock the pre-merge test issue |
This is the same PR as in Project-MONAI#5523 but removing changes to default ensemble method (AlgoEnsembleBestByFold), and keeping it as is for now, since it triggers errors with some unit tests. the default ensemble method update can be done in a separate PR. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: myron <[email protected]>
Fixes Project-MONAI#5553 ### Description Promote specified children of specified items to the level of item. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
update-probmap-outputdir
branch
from
365c3ac to
0fb1542
Compare
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5566
Types of changes