Fix wrong algorithm folder name parsing in ensemble after HPO in Auto3DSeg#5561
Merged
wyli merged 1 commit intoProject-MONAI:devfrom Nov 22, 2022
mingxin-zheng:fix-5558
Merged
Fix wrong algorithm folder name parsing in ensemble after HPO in Auto3DSeg#5561wyli merged 1 commit intoProject-MONAI:devfrom mingxin-zheng:fix-5558
wyli merged 1 commit intoProject-MONAI:devfrom
mingxin-zheng:fix-5558
Conversation
Signed-off-by: Mingxin Zheng <[email protected]>
mingxin-zheng
changed the title
wyli
approved these changes
Nov 22, 2022
Contributor
|
/build |
Collaborator
|
mmm , I'm okay with this change. I think we can merge it, and think of a better way to track the fold number , instead of parsing the name of the folder/algorithm |
myron
approved these changes
Nov 22, 2022
bhashemian
pushed a commit
to bhashemian/MONAI
that referenced
this pull request
Nov 23, 2022
…3DSeg (Project-MONAI#5561) Signed-off-by: Mingxin Zheng <[email protected]> Fixes Project-MONAI#5558 . ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] Integration tests passed locally by running `python tests/test_integration_autorunner.py`. Signed-off-by: Mingxin Zheng <[email protected]> Signed-off-by: Behrooz <[email protected]>
bhashemian
pushed a commit
to bhashemian/MONAI
that referenced
this pull request
Nov 23, 2022
…3DSeg (Project-MONAI#5561) Signed-off-by: Mingxin Zheng <[email protected]> Fixes Project-MONAI#5558 . ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] Integration tests passed locally by running `python tests/test_integration_autorunner.py`. Signed-off-by: Mingxin Zheng <[email protected]> Signed-off-by: Behrooz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mingxin Zheng [email protected]
Fixes #5558 .
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
python tests/test_integration_autorunner.py.