Skip to content

Fix AutoRunner Update Integration Test Errors#5557

Closed
mingxin-zheng wants to merge 2 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-5555
Closed

Fix AutoRunner Update Integration Test Errors#5557
mingxin-zheng wants to merge 2 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-5555

Conversation

@mingxin-zheng
Copy link
Copy Markdown
Contributor

@mingxin-zheng mingxin-zheng commented Nov 22, 2022

Signed-off-by: Mingxin Zheng [email protected]

Fixes #5555 .

The following command fails after the update.

python tests/test_integration_autorunner.py

Description

  • fix identifier naming bug for HPO AutoRunner runs
  • fix NoneType elements in the ensemble algorithm lists
  • move optional argument algos to the end of the argument list (this is still up for more discussion I think)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@mingxin-zheng
fix integration test failure
36418f0 
Signed-off-by: Mingxin Zheng <[email protected]>
wyli
wyli requested changes Nov 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by patching the buggy PR this quick fix introduces more issues... for example now the position of algos in the AutoRunner docstring is not consistent with the function's arguments.

This was referenced Nov 22, 2022
Merged
Merged
@mingxin-zheng
docstring updated
55c266b 
Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng
Copy link
Copy Markdown
Contributor Author

mingxin-zheng commented Nov 22, 2022 •
edited
Loading

Understood @wyli . As I mention, the position of algos is up for discussion. I'm not sure what's right to do there.
The rest is to pinpoint where the bugs are (and I think they're partly from the original AutoRunner before the PR).

@mingxin-zheng
Copy link
Copy Markdown
Contributor Author

mingxin-zheng commented Nov 22, 2022

Closing this PR as these issues should be fixed separately.

@mingxin-zheng mingxin-zheng deleted the fix-5555 branch December 1, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mingxin-zheng @wyli