Skip to content

5385 Add support to override experiment tracking configs#5556

Merged
wyli merged 20 commits intoProject-MONAI:devfrom
Nic-Ma:5385-settings-override
Nov 24, 2022
Merged

5385 Add support to override experiment tracking configs#5556
wyli merged 20 commits intoProject-MONAI:devfrom
Nic-Ma:5385-settings-override

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Nov 22, 2022

Part of #5385 .

Description

This PR added support to override the predefined configs in the experiment tracking settings.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 22, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 22, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 22, 2022 •
edited
Loading

Hi @wyli , @binliunls ,

Usage examples:

  1. run bundle training without experiment management:
    python -m monai.bundle run training --meta_file configs/metadata.json --config_file configs/train.json

  2. run bundle training with MLFlow default settings:
    python -m monai.bundle run training --meta_file configs/metadata.json --config_file configs/train.json --tracking mlflow

  3. run bundle training with MLFlow default settings and override "tracking_uri" at runtime:
    python -m monai.bundle run training --meta_file configs/metadata.json --config_file configs/train.json --tracking mlflow --tracking_uri "<my path>"

  4. run bundle training with tracking settings from a JSON file:
    python -m monai.bundle run training --meta_file configs/metadata.json --config_file configs/train.json --logging_file configs/logging.conf --tracking configs/mlflow_settings.json

  5. run bundle training with tracking settings from a JSON file and override "tracking_uri" at runtime:
    python -m monai.bundle run training --meta_file configs/metadata.json --config_file configs/train.json --tracking configs/mlflow_settings.json --tracking_uri "<my path>"

We will make a tutorial to describe more example details soon.

Thanks.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 22, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 22, 2022

/build

1 similar comment
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 23, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 23, 2022

/build

binliunls
binliunls reviewed Nov 23, 2022
View reviewed changes
@Nic-Ma Nic-Ma requested a review from binliunls November 23, 2022 17:40
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 23, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 23, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 24, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Nov 24, 2022

/build

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 24, 2022

/build

@wyli wyli enabled auto-merge (squash) November 24, 2022 14:41
@wyli wyli merged commit ec90edc into Project-MONAI:dev Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@mingxin-zheng mingxin-zheng Awaiting requested review from mingxin-zheng

@binliunls binliunls Awaiting requested review from binliunls

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nic-Ma @wyli @binliunls