Skip to content

5530 Gradcam for models that return a single value#5547

Closed
thatgeeman wants to merge 7 commits intoProject-MONAI:devfrom
thatgeeman:5530-gradcam
Closed

5530 Gradcam for models that return a single value#5547
thatgeeman wants to merge 7 commits intoProject-MONAI:devfrom
thatgeeman:5530-gradcam

Conversation

@thatgeeman
Copy link
Copy Markdown
Contributor

@thatgeeman thatgeeman commented Nov 20, 2022

Fixes #5530

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@thatgeeman thatgeeman marked this pull request as draft November 20, 2022 21:38
@thatgeeman
Copy link
Copy Markdown
Contributor Author

thatgeeman commented Dec 5, 2022

Closing, cf:

thanks for looking into this @thatgeeman, indeed it's already supported. I'm closing this and please help update one of the test cases for the single channel output if you are interested...

MONAI/tests/test_vis_gradcam.py

Line 103 in 7614aca

def test_shape(self, cam_class, input_data, expected_shape):

@thatgeeman thatgeeman closed this Dec 5, 2022
@thatgeeman thatgeeman deleted the 5530-gradcam branch December 5, 2022 12:17
@thatgeeman thatgeeman mentioned this pull request Dec 5, 2022
Merged
3 tasks
wyli pushed a commit that referenced this pull request Dec 5, 2022
@thatgeeman
test vis gradcam for binary classification task (#5654)
90f1893 
Follow up of issue #5530 #5528 and (closed) PR #5547

### Description

Add test case for a binary classification task in `test_vis_gradcam`

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] New tests added to cover the changes.  
- [x] In-line docstrings updated.

Signed-off-by: Geevarghese George <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gradcam for models that return a single value

1 participant

@thatgeeman