DataAnalyzer fixes#5536
Merged
wyli merged 17 commits intoProject-MONAI:devfrom Nov 21, 2022
myron:analyzer
Merged
Conversation
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
wyli
reviewed
Nov 17, 2022
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
mingxin-zheng
approved these changes
Nov 21, 2022
Contributor
There was a problem hiding this comment.
Thanks @myron for fixing the data analyzer. It looks good to me.
I made some minor comments above and please feel free to skip them. I marked them as "resolved" because neither of it should be blocking the merge.
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Contributor
|
/build |
bhashemian
pushed a commit
to bhashemian/MONAI
that referenced
this pull request
Nov 23, 2022
This adds several non-breaking fixes to DataAnalyzer - do_ccp option defaults to False (as we don't currently use it, and it's pretty slow) - on GPU, dataloading is in parallel (num_workers = self.workers), previously it was only synchronous - when label for one case is completely empty (no foreground), it crashes, so this PR fixes, by putting all zeros in label status this PR partially addresses Project-MONAI#5430 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: myron <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Behrooz <[email protected]>
bhashemian
pushed a commit
to bhashemian/MONAI
that referenced
this pull request
Nov 23, 2022
This adds several non-breaking fixes to DataAnalyzer - do_ccp option defaults to False (as we don't currently use it, and it's pretty slow) - on GPU, dataloading is in parallel (num_workers = self.workers), previously it was only synchronous - when label for one case is completely empty (no foreground), it crashes, so this PR fixes, by putting all zeros in label status this PR partially addresses Project-MONAI#5430 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: myron <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Behrooz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds several non-breaking fixes to DataAnalyzer
this PR partially addresses #5430
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.