Conversation
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
wyli
left a comment
There was a problem hiding this comment.
code looks good to me, I'm not sure about the class name RandomOrder, to me the operation is similar with np.random.shuffle https://numpy.org/doc/stable/reference/random/generated/numpy.random.shuffle.html
Yes, actually I'm referring to the name of torchvision. |
Ok, that's also implemented with a 'shuffle'. Any particular reason that permutation is used in this implementation? |
Yes, since MONAI/monai/transforms/compose.py Line 126 in 624e832 Thanks! |
Since the transforms are changed at every iteration, perhaps change it to a list and then shuffle the list is more efficient |
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
|
/build |
Part of #5517.
Description
When we have a list of transforms, we may want these transforms to do in random order. Add
RandomOrderwhich is a subclass ofComposeto provide the ability to apply a list of transformations in random order.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.