Skip to content

5532 tensor.shape in tensor.Size#5533

Merged
Nic-Ma merged 6 commits intoProject-MONAI:devfrom
wyli:5532-shape-Size
Nov 17, 2022
Merged

5532 tensor.shape in tensor.Size#5533
Nic-Ma merged 6 commits intoProject-MONAI:devfrom
wyli:5532-shape-Size

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Nov 15, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #5532

Description

returns early if it's torch.Size

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli marked this pull request as ready for review November 15, 2022 22:49
@Nic-Ma Nic-Ma requested a review from myron November 16, 2022 00:17
wyli added 3 commits November 16, 2022 09:32
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @myron , do you have any other comments?

Thanks.

@myron
Copy link
Copy Markdown
Collaborator

myron commented Nov 17, 2022

Hi @myron , do you have any other comments?

Thanks.

this looks very good, thanks @wyli , it's a more general fix

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 17, 2022 03:46
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Nov 17, 2022

/build

@Nic-Ma Nic-Ma merged commit 624e832 into Project-MONAI:dev Nov 17, 2022
bhashemian pushed a commit to bhashemian/MONAI that referenced this pull request Nov 23, 2022
Signed-off-by: Wenqi Li <[email protected]>

Fixes Project-MONAI#5532 

### Description
returns early if it's torch.Size

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <[email protected]>
Co-authored-by: Nic Ma <[email protected]>
Signed-off-by: Behrooz <[email protected]>
@wyli wyli deleted the 5532-shape-Size branch December 13, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: MetaTensor .shape() returns Tuple instead of torch.Size

3 participants