fixes init bundle pytorch versioning#5529
Closed
wyli wants to merge 2 commits intoProject-MONAI:devfrom
Closed
Conversation
Signed-off-by: Wenqi Li <[email protected]>
yiheng-wang-nv
approved these changes
Nov 16, 2022
Contributor
Author
|
thanks @yiheng-wang-nv I'll include this patch in #5480 as it's a minor thing for the bundle workflow. |
7 tasks
Nic-Ma
added a commit
that referenced
this pull request
Nov 16, 2022
Signed-off-by: Wenqi Li <[email protected]> ### Description this PR includes a few minor improvements - allow string input, such as `device="cuda:1"` for Workflow - skip stats key metric if `key_metric_name` is None (monai/handlers/stats_handler.py) - print incompatible metric values in the warning message (CheckpointSaver) - adds a `epochs` parameter for `ShuffleBuffer` (#5488) - adds a `output_name_formatter` for `SaveImage` (#5508) - simplify torch version in bundle init (#5529) ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: Nic Ma <[email protected]> Co-authored-by: Nic Ma <[email protected]>
bhashemian
pushed a commit
to bhashemian/MONAI
that referenced
this pull request
Nov 23, 2022
Signed-off-by: Wenqi Li <[email protected]> ### Description this PR includes a few minor improvements - allow string input, such as `device="cuda:1"` for Workflow - skip stats key metric if `key_metric_name` is None (monai/handlers/stats_handler.py) - print incompatible metric values in the warning message (CheckpointSaver) - adds a `epochs` parameter for `ShuffleBuffer` (Project-MONAI#5488) - adds a `output_name_formatter` for `SaveImage` (Project-MONAI#5508) - simplify torch version in bundle init (Project-MONAI#5529) ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: Nic Ma <[email protected]> Co-authored-by: Nic Ma <[email protected]> Signed-off-by: Behrooz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes Project-MONAI/model-zoo#201 (comment)
Description
the pypi version might be
1.13.0+cu117the docker image version might be
1.9.0a0+df837d0Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.