AutoRunner small updates#5523
Conversation
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
Signed-off-by: myron <[email protected]>
|
Hi @myron , thanks for creating the MR and I have two minor comments. Everything else looks fine to me. |
|
/build |
|
this seems to break the integration tests, shall we revert and double-check? |
@wyli can I ask where are these integration tests and how to run it? They all seems to pass on my local machine and during PR submission. |
|
yes, mainly these commands: MONAI/.github/workflows/cron.yml Lines 107 to 108 in 7213060 there are some more details in the contributing guide: https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md |
AutoRunner() non-breaking class updates, to add more options - adding and option self.algos to manually specify algorithms to run (instead of always downloading a zip) - Input options train, algo_gen, analyze will default to None, indicating to automatically decide whether this step is necessary based on cache (history). - default ensemble method is changed to AlgoEnsembleBestByFold - added method set_analyze_params() to set DataAnalyser parameters (e.g. run it on gpu) - changed self.cache dict to be a single level (since it only has 4 items), instead of a nested dictionary - removed default setting sigmoid=True in set_prediction_params(), since it's somewhat arbitrary ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: myron <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Behrooz <[email protected]>
Reverts Project-MONAI#5523 Signed-off-by: Behrooz <[email protected]>
AutoRunner() non-breaking class updates, to add more options - adding and option self.algos to manually specify algorithms to run (instead of always downloading a zip) - Input options train, algo_gen, analyze will default to None, indicating to automatically decide whether this step is necessary based on cache (history). - default ensemble method is changed to AlgoEnsembleBestByFold - added method set_analyze_params() to set DataAnalyser parameters (e.g. run it on gpu) - changed self.cache dict to be a single level (since it only has 4 items), instead of a nested dictionary - removed default setting sigmoid=True in set_prediction_params(), since it's somewhat arbitrary ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: myron <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Behrooz <[email protected]>
Reverts Project-MONAI#5523 Signed-off-by: Behrooz <[email protected]>
This is the same PR as in #5523 but removing changes to default ensemble method (AlgoEnsembleBestByFold), and keeping it as is for now, since it triggers errors with some unit tests. the default ensemble method update can be done in a separate PR. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: myron <[email protected]>
This is the same PR as in Project-MONAI#5523 but removing changes to default ensemble method (AlgoEnsembleBestByFold), and keeping it as is for now, since it triggers errors with some unit tests. the default ensemble method update can be done in a separate PR. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: myron <[email protected]>
AutoRunner() non-breaking class updates, to add more options
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.