Skip to content

5515 Adjust freeze encoder of hovernet#5518

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
yiheng-wang-nv:5515-adjust-eocoder-freeze-for-hovernet
Nov 14, 2022
Merged

5515 Adjust freeze encoder of hovernet#5518
wyli merged 3 commits intoProject-MONAI:devfrom
yiheng-wang-nv:5515-adjust-eocoder-freeze-for-hovernet

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

Signed-off-by: Yiheng Wang [email protected]

Fixes #5515 .

Description

This PR adjusts the freeze encoder function, and also fix the issue of un-trigger some of the unit tests.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 14, 2022

/build

@wyli wyli enabled auto-merge (squash) November 14, 2022 16:13
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 14, 2022

/build

Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 14, 2022

/build

1 similar comment
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 14, 2022

/build

@wyli wyli merged commit 5332187 into Project-MONAI:dev Nov 14, 2022
@yiheng-wang-nv yiheng-wang-nv deleted the 5515-adjust-eocoder-freeze-for-hovernet branch November 15, 2022 02:02
bhashemian pushed a commit to bhashemian/MONAI that referenced this pull request Nov 23, 2022
Signed-off-by: Yiheng Wang <[email protected]>

Fixes Project-MONAI#5515  .

### Description

This PR adjusts the freeze encoder function, and also fix the issue of
un-trigger some of the unit tests.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust the encoder freeze function on HoverNet

3 participants