Update with the changes in sobel gradients#5503
Update with the changes in sobel gradients#5503bhashemian merged 8 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Behrooz <[email protected]>
JHancox
left a comment
JHancox
left a comment
There was a problem hiding this comment.
One question - is there any practical reason not to use the channel for the batch (apart from the fact that it is called 'channel' and not 'batch')? If not then perhaps we should generalize Sobel so that it can take either (or both). Just a thought.
That's a good point! I avoided it because of clarity but now that you are mentioning it, I think why not! I will make the change and also update the SobelGradients docstring to make it clear that it can be channel or batch! |
Signed-off-by: Behrooz <[email protected]>
|
@KumoLiu please help check with the training pipeline |
Yes, I'm checking right now! |
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
|
Hi @Nic-Ma, could you please help to merge this PR? Thanks |
|
/build |
Fixes Project-MONAI#5500 ### Description Update `HoVerNetLoss` with the improvements and changes in `SobelGradients`. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). Signed-off-by: Behrooz <[email protected]>
Signed-off-by: KumoLiu <[email protected]> Fixes #5750. ### Description Change dim in Sobel gradient which have been discussed in #5503. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: KumoLiu <[email protected]>
5 participants
Fixes #5500
Description
Update
HoVerNetLosswith the improvements and changes inSobelGradients.Types of changes