#5498 issues fix pull request for SSIMMetric#5502
Merged
wyli merged 17 commits intoProject-MONAI:devfrom Nov 10, 2022
Merged
Conversation
It is related with Project-MONAI#5498 issue
fix initialisation for regressionmetric ( parent class)
DCO Remediation Commit for Joeycho <[email protected]> I, Joeycho <[email protected]>, hereby add my Signed-off-by to this commit: 75f6c53 I, Joeycho <[email protected]>, hereby add my Signed-off-by to this commit: 57a7a6f Signed-off-by: Joeycho <[email protected]>
Contributor
|
/black MONAI/tests/test_ssim_metric.py Lines 40 to 43 in a6ae2be |
wyli
changed the title
Contributor
Author
DCO Remediation Commit for Joeycho <[email protected]> I, Joeycho <[email protected]>, hereby add my Signed-off-by to this commit: a444ea8 Signed-off-by: Joeycho <[email protected]>
Signed-off-by: Joeycho <[email protected]>
Signed-off-by: Joeycho <[email protected]>
wyli
reviewed
Nov 10, 2022
Fix metric to report ssim_value per each one in batch, not all. SSIMLoss returns mean() for all in batches. That causes issue in Metric. In Loss, it is fine. Signed-off-by: Joeycho <[email protected]>
Signed-off-by: Joeycho <[email protected]>
Signed-off-by: Joeycho <[email protected]>
Signed-off-by: monai-bot <[email protected]>
Contributor
|
/build |
wyli
approved these changes
Nov 10, 2022
bhashemian
pushed a commit
to bhashemian/MONAI
that referenced
this pull request
Nov 23, 2022
…NAI#5502) Fixes Project-MONAI#5498 ### Description simply add arguments (reduction and get_not_nans) for parent class and update ssim loss function to inherit loss, not nn.module. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Joeycho <[email protected]> Signed-off-by: Behrooz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5498
Description
simply add arguments (reduction and get_not_nans) for parent class and update ssim loss function to inherit loss, not nn.module.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.