Skip to content

Install dependencies on Mac#5492

Merged
bhashemian merged 3 commits intoProject-MONAI:devfrom
bhashemian:mac-dep-requirements
Nov 9, 2022
Merged

Install dependencies on Mac#5492
bhashemian merged 3 commits intoProject-MONAI:devfrom
bhashemian:mac-dep-requirements

Conversation

@bhashemian
Copy link
Copy Markdown
Member

@bhashemian bhashemian commented Nov 8, 2022

Description

Few MONAI dependencies are flagged to be installed only on a Linux system while they are available on Macintosh systems too. This PR fix that to include imagecodecs and tifffile.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@bhashemian bhashemian requested review from Nic-Ma and wyli November 8, 2022 20:45
@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Nov 9, 2022

@wyli @Nic-Ma do these changes looks good to you?

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 9, 2022

could you please re-enable the relevant tests to confirm the usage?

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Nov 9, 2022

could you please re-enable the relevant tests to confirm the usage?

@wyli may I know which tests do you mean?

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Nov 9, 2022 •
edited
Loading

We have excluded tests based on the existence of a library and not based on the platform, so they should be enabled automatically.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 9, 2022 •
edited
Loading

We have excluded tests based on the existence of a library and not based on the platform, so they should be enabled automatically.

so which tests are enabled now?

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Nov 9, 2022

We have excluded tests based on the existence of a library and not based on the platform, so they should be enabled automatically.

so which tests are enabled now?

tests/test_wsireader.py for TiffFile backend should be enabled on Mac.

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented Nov 9, 2022

https://github.com/Project-MONAI/MONAI/actions/runs/3429146901/jobs/5714369965#step:11:19135

@bhashemian bhashemian enabled auto-merge (squash) November 9, 2022 18:07
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 9, 2022

/build

@bhashemian bhashemian merged commit cd29a5b into Project-MONAI:dev Nov 9, 2022
@bhashemian bhashemian deleted the mac-dep-requirements branch November 9, 2022 19:18
bhashemian added a commit to bhashemian/MONAI that referenced this pull request Nov 23, 2022
@bhashemian
Install dependencies on Mac (Project-MONAI#5492)
61a3d86 
Signed-off-by: Behrooz <[email protected]>
@KumoLiu KumoLiu mentioned this pull request Dec 9, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhashemian @wyli