Skip to content

implemented F_beta score#5490

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
Fasicek:4392-fbeta-instead-of-f1-only
Nov 9, 2022
Merged

implemented F_beta score#5490
wyli merged 8 commits intoProject-MONAI:devfrom
Fasicek:4392-fbeta-instead-of-f1-only

Conversation

@Fasicek
Copy link
Copy Markdown
Contributor

@Fasicek Fasicek commented Nov 8, 2022

Signed-off-by: Roland Kica [email protected]

Description

Implementing F beta score based on Confusion matrix metric

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 9, 2022

/black

Roland Kica added 3 commits November 9, 2022 19:24
I, Roland Kica <[email protected]>, hereby add my Signed-off-by to this commit: faf04c4
I, Roland Kica <[email protected]>, hereby add my Signed-off-by to this commit: bf9efa0
I, Roland Kica <[email protected]>, hereby add my Signed-off-by to this commit: e39aa0e

Signed-off-by: Roland Kica <[email protected]>
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it looks good to me, I'll remove the if __name__ == "__main__" entry point and merge this PR.

@wyli wyli enabled auto-merge (squash) November 9, 2022 22:09
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 9, 2022

/build

@wyli wyli merged commit f9ea9d8 into Project-MONAI:dev Nov 9, 2022
@wyli wyli mentioned this pull request Nov 11, 2022
bhashemian pushed a commit to bhashemian/MONAI that referenced this pull request Nov 23, 2022
Signed-off-by: Roland Kica <[email protected]>

### Description

Implementing F beta score based on Confusion matrix metric

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Roland Kica <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants