Skip to content

minor usability enh bundle workflow#5480

Merged
Nic-Ma merged 19 commits intoProject-MONAI:devfrom
wyli:usability-improve
Nov 16, 2022
Merged

minor usability enh bundle workflow#5480
Nic-Ma merged 19 commits intoProject-MONAI:devfrom
wyli:usability-improve

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Nov 5, 2022

Signed-off-by: Wenqi Li [email protected]

Description

this PR includes a few minor improvements

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli added this to the Registration bundle [P0 v1.1] milestone Nov 5, 2022
@wyli wyli force-pushed the usability-improve branch from 0897c0e to 5335faf Compare November 5, 2022 19:02
@wyli wyli self-assigned this Nov 7, 2022
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Nov 9, 2022

/build

@wyli wyli marked this pull request as ready for review November 10, 2022 23:29
@wyli wyli force-pushed the usability-improve branch from eabe082 to 8d73ff9 Compare November 16, 2022 09:00
@wyli wyli mentioned this pull request Nov 16, 2022
7 tasks
@wyli wyli requested a review from Nic-Ma November 16, 2022 09:41
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Nov 16, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Nov 16, 2022

Looks good to me.
Thanks for the quick update.

@wyli wyli enabled auto-merge (squash) November 16, 2022 11:39
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Nov 16, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Nov 16, 2022

Hi @wyli ,

I will put a minor fix in this PR for an outdated link, if you don't agree, please feel free to revert it.

Thanks.

@Nic-Ma Nic-Ma disabled auto-merge November 16, 2022 14:09
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Nov 16, 2022

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 16, 2022 15:04
@Nic-Ma Nic-Ma merged commit d51edc3 into Project-MONAI:dev Nov 16, 2022
@wyli wyli deleted the usability-improve branch November 16, 2022 15:48
bhashemian pushed a commit to bhashemian/MONAI that referenced this pull request Nov 23, 2022
Signed-off-by: Wenqi Li <[email protected]>

### Description
this PR includes a few minor improvements
- allow string input, such as `device="cuda:1"` for Workflow
- skip stats key metric if `key_metric_name` is None
(monai/handlers/stats_handler.py)
- print incompatible metric values in the warning message
(CheckpointSaver)
- adds a `epochs` parameter for `ShuffleBuffer`
(Project-MONAI#5488)
- adds a `output_name_formatter` for `SaveImage`
(Project-MONAI#5508)
- simplify torch version in bundle init
(Project-MONAI#5529)

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Co-authored-by: Nic Ma <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants