Merged
Conversation
wyli
force-pushed
the
5431-torch-add113-drop17
branch
2 times, most recently
from
8c538ef to
5f0bac7
Compare
YanxuanLiu
changed the title
wyli
force-pushed
the
5431-torch-add113-drop17
branch
2 times, most recently
from
d9f1f3e to
76cc73d
Compare
wyli
changed the title
Contributor
Author
|
seems to work fine with the github runner, would be great to test the same environments for blossom @YanxuanLiu before you approve this PR |
YanxuanLiu
reviewed
Nov 4, 2022
wyli
force-pushed
the
5431-torch-add113-drop17
branch
from
d80cbd3 to
abc58b3
Compare
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Lee Newberg <[email protected]> Re-writes version numbers as strings rather than numbers because 3.1 != 3.10, etc. Nothing is broken at present but in the future as, e.g., the Python version for some things goes from 3.8 to 3.9 to 3.10, this could end up being an unexpected problem. <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). Signed-off-by: Lee Newberg <[email protected]> Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
5431-torch-add113-drop17
branch
from
c0fc5ae to
c23f06b
Compare
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
Contributor
Author
|
this is tested on blossom @YanxuanLiu @Nic-Ma I think it's ready |
Contributor
Author
|
/build |
Nic-Ma
approved these changes
Nov 7, 2022
Contributor
Author
|
/build |
bhashemian
pushed a commit
to bhashemian/MONAI
that referenced
this pull request
Nov 23, 2022
Fixes Project-MONAI#5431 Fixes Project-MONAI#5452 ### Description - deprecating pytorch 1.7 tests - adds pytorch 1.13 tests - upgrade base image to pytorch 22.10 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: Behrooz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5431
Fixes #5452
Description
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.