Versions as strings, not numbers, so that 3.1 != 3.10, etc.#5456
Merged
wyli merged 1 commit intoProject-MONAI:devfrom Nov 2, 2022
Leengit:quoting_version
Merged
Versions as strings, not numbers, so that 3.1 != 3.10, etc.#5456wyli merged 1 commit intoProject-MONAI:devfrom Leengit:quoting_version
wyli merged 1 commit intoProject-MONAI:devfrom
Leengit:quoting_version
Conversation
Signed-off-by: Lee Newberg <[email protected]>
wyli
approved these changes
Nov 2, 2022
Contributor
|
/build |
wyli
added a commit
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Lee Newberg <[email protected]> Re-writes version numbers as strings rather than numbers because 3.1 != 3.10, etc. Nothing is broken at present but in the future as, e.g., the Python version for some things goes from 3.8 to 3.9 to 3.10, this could end up being an unexpected problem. <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). Signed-off-by: Lee Newberg <[email protected]> Signed-off-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
Nov 3, 2022
Signed-off-by: Lee Newberg <[email protected]> Re-writes version numbers as strings rather than numbers because 3.1 != 3.10, etc. Nothing is broken at present but in the future as, e.g., the Python version for some things goes from 3.8 to 3.9 to 3.10, this could end up being an unexpected problem. <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). Signed-off-by: Lee Newberg <[email protected]> Signed-off-by: Wenqi Li <[email protected]>
wyli
added a commit
to wyli/MONAI
that referenced
this pull request
Nov 6, 2022
…MONAI#5456) Signed-off-by: Lee Newberg <[email protected]> Re-writes version numbers as strings rather than numbers because 3.1 != 3.10, etc. Nothing is broken at present but in the future as, e.g., the Python version for some things goes from 3.8 to 3.9 to 3.10, this could end up being an unexpected problem. <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). Signed-off-by: Lee Newberg <[email protected]> Signed-off-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lee Newberg [email protected]
Description
Re-writes version numbers as strings rather than numbers because 3.1 != 3.10, etc. Nothing is broken at present but in the future as, e.g., the Python version for some things goes from 3.8 to 3.9 to 3.10, this could end up being an unexpected problem.
Types of changes