Skip to content

Versions as strings, not numbers, so that 3.1 != 3.10, etc.#5456

Merged
wyli merged 1 commit intoProject-MONAI:devfrom
Leengit:quoting_version
Nov 2, 2022
Merged

Versions as strings, not numbers, so that 3.1 != 3.10, etc.#5456
wyli merged 1 commit intoProject-MONAI:devfrom
Leengit:quoting_version

Conversation

@Leengit
Copy link
Copy Markdown
Contributor

@Leengit Leengit commented Nov 2, 2022

Signed-off-by: Lee Newberg [email protected]

Description

Re-writes version numbers as strings rather than numbers because 3.1 != 3.10, etc. Nothing is broken at present but in the future as, e.g., the Python version for some things goes from 3.8 to 3.9 to 3.10, this could end up being an unexpected problem.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Nov 2, 2022

/build

@wyli wyli enabled auto-merge (squash) November 2, 2022 17:11
@wyli wyli merged commit b05ef9c into Project-MONAI:dev Nov 2, 2022
@Leengit Leengit deleted the quoting_version branch November 2, 2022 17:46
wyli added a commit that referenced this pull request Nov 2, 2022
Signed-off-by: Lee Newberg <[email protected]>

Re-writes version numbers as strings rather than numbers because 3.1 !=
3.10, etc. Nothing is broken at present but in the future as, e.g., the
Python version for some things goes from 3.8 to 3.9 to 3.10, this could
end up being an unexpected problem.

<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).

Signed-off-by: Lee Newberg <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit that referenced this pull request Nov 3, 2022
Signed-off-by: Lee Newberg <[email protected]>

Re-writes version numbers as strings rather than numbers because 3.1 !=
3.10, etc. Nothing is broken at present but in the future as, e.g., the
Python version for some things goes from 3.8 to 3.9 to 3.10, this could
end up being an unexpected problem.

<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).

Signed-off-by: Lee Newberg <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli added a commit to wyli/MONAI that referenced this pull request Nov 6, 2022
…MONAI#5456)

Signed-off-by: Lee Newberg <[email protected]>

Re-writes version numbers as strings rather than numbers because 3.1 !=
3.10, etc. Nothing is broken at present but in the future as, e.g., the
Python version for some things goes from 3.8 to 3.9 to 3.10, this could
end up being an unexpected problem.

<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).

Signed-off-by: Lee Newberg <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants