Merged
Conversation
Signed-off-by: Wenqi Li <[email protected]>
wyli
requested review from
Nic-Ma,
atbenmurray,
ericspod,
rijobro and
yiheng-wang-nv
yiheng-wang-nv
approved these changes
Nov 2, 2022
Contributor
yiheng-wang-nv
left a comment
yiheng-wang-nv
left a comment
There was a problem hiding this comment.
Thanks! It helps a lot for those PRs that have multiple commits and/or multiple contributors
Contributor
Author
|
/build |
Nic-Ma
approved these changes
Nov 2, 2022
wyli
added a commit
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Wenqi Li <[email protected]> it's not easy to always keep the dco signing-off line when the pull requests have many commits and rebasing. And the current instructions of rebasing commits for DCO don't work properly in many cases ([example](https://github.com/Project-MONAI/MONAI/pull/5377/checks?check_run_id=9245758301)). This PR set the option https://github.com/dcoapp/app#individual-remediation-commit-support so that the signing-off could be done via follow-up commits retroactively. the new instructions for signing the PR will be provided similarly to this testing example: https://github.com/gr2m/sandbox/runs/4221328432 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
it's not easy to always keep the dco signing-off line when the pull requests have many commits and rebasing. And the current instructions of rebasing commits for DCO don't work properly in many cases (example). This PR set the option https://github.com/dcoapp/app#individual-remediation-commit-support so that the signing-off could be done via follow-up commits retroactively.
the new instructions for signing the PR will be provided similarly to this testing example:
https://github.com/gr2m/sandbox/runs/4221328432
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.