5381 and deprecate compute_meandice compute_meaniou#5382
Merged
wyli merged 3 commits intoProject-MONAI:devfrom Oct 24, 2022
Merged
5381 and deprecate compute_meandice compute_meaniou#5382wyli merged 3 commits intoProject-MONAI:devfrom
compute_meandice compute_meaniou#5382wyli merged 3 commits intoProject-MONAI:devfrom
Conversation
wyli
requested review from
Nic-Ma,
ericspod,
mingxin-zheng,
rijobro and
yiheng-wang-nv
wyli
changed the title
__all____all__
Member
|
If we're looking at |
wyli
changed the title
__all__compute_meandice compute_meaniou
Contributor
|
Looks good to me. |
mingxin-zheng
approved these changes
Oct 24, 2022
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
5381-update-func-name
branch
from
82b0885 to
8b3cc84
Compare
Contributor
Author
|
/build |
Contributor
Author
thanks Mingxin, this patch will be included in v1.0.1, and agree that we should update the templates. It's also fine if we don't have time to update the template hash value for v1.0.1, because by default the deprecation warning will be printed only on the first occurrence within each run. |
wyli
added a commit
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Wenqi Li <[email protected]> Fixes #5381 ### Description - non-breaking changes to rename `compute_meandice` to `compute_dice` - non-breaking changes to rename `compute_meaniou` to `compute_iou` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
Oct 24, 2022
Signed-off-by: Wenqi Li <[email protected]> Fixes #5381 - non-breaking changes to rename `compute_meandice` to `compute_dice` - non-breaking changes to rename `compute_meaniou` to `compute_iou` <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Wenqi Li <[email protected]> Fixes #5381 ### Description - non-breaking changes to rename `compute_meandice` to `compute_dice` - non-breaking changes to rename `compute_meaniou` to `compute_iou` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: KumoLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #5381
Description
compute_meandicetocompute_dicecompute_meanioutocompute_iouTypes of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.