Remove meta_dict and fix affine to spacing conversion#5367
Merged
wyli merged 4 commits intoProject-MONAI:devfrom Oct 20, 2022
mingxin-zheng:fix-5201-5332
Merged
Remove meta_dict and fix affine to spacing conversion#5367wyli merged 4 commits intoProject-MONAI:devfrom mingxin-zheng:fix-5201-5332
wyli merged 4 commits intoProject-MONAI:devfrom
mingxin-zheng:fix-5201-5332
Conversation
Signed-off-by: Mingxin Zheng <[email protected]>
Contributor
|
/black |
mingxin-zheng
changed the title
wyli
reviewed
Oct 20, 2022
Signed-off-by: Mingxin Zheng <[email protected]>
mingxin-zheng
changed the title
wyli
approved these changes
Oct 20, 2022
Contributor
|
/build |
wyli
pushed a commit
that referenced
this pull request
Oct 20, 2022
Signed-off-by: Mingxin Zheng <[email protected]> Fixes #5201 Fixes #5332 ### Description - Remove deprecated meta_dict usage from Auto3DSeg. - Fix affine -> spacing conversion - Update docstring - Change "pixel_percentage" to "foreground_percentage" to unify foreground "pixel"/"voxel" naming ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] In-line docstrings updated. Signed-off-by: Mingxin Zheng <[email protected]>
bhashemian
pushed a commit
to JHancox/MONAI
that referenced
this pull request
Oct 21, 2022
…5367) Signed-off-by: Mingxin Zheng <[email protected]> Fixes Project-MONAI#5201 Fixes Project-MONAI#5332 ### Description - Remove deprecated meta_dict usage from Auto3DSeg. - Fix affine -> spacing conversion - Update docstring - Change "pixel_percentage" to "foreground_percentage" to unify foreground "pixel"/"voxel" naming ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] In-line docstrings updated. Signed-off-by: Mingxin Zheng <[email protected]> Signed-off-by: Behrooz <[email protected]>
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Mingxin Zheng <[email protected]> Fixes #5201 Fixes #5332 ### Description - Remove deprecated meta_dict usage from Auto3DSeg. - Fix affine -> spacing conversion - Update docstring - Change "pixel_percentage" to "foreground_percentage" to unify foreground "pixel"/"voxel" naming ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] In-line docstrings updated. Signed-off-by: Mingxin Zheng <[email protected]> Signed-off-by: KumoLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mingxin Zheng [email protected]
Fixes #5201
Fixes #5332
Description
Status
Ready for review
Types of changes