Skip to content

A small update to to ensure ds_loss returns a const#5350

Merged
wyli merged 14 commits intoProject-MONAI:devfrom
myron:ds_loss
Oct 19, 2022
Merged

A small update to to ensure ds_loss returns a const#5350
wyli merged 14 commits intoProject-MONAI:devfrom
myron:ds_loss

Conversation

@myron
Copy link
Copy Markdown
Collaborator

@myron myron commented Oct 17, 2022

A small fix to followup on #5338
to ensure ds_loss returns a constant, not an array

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@myron myron added the enhancement New feature or request label Oct 17, 2022
@myron myron added this to the Auto3D Seg framework [P0 v1.0] milestone Oct 17, 2022
@myron myron changed the title Ds loss A small update to to ensure ds_loss returns a const Oct 17, 2022
@mingxin-zheng
Copy link
Copy Markdown
Contributor

Hi @myron I saw this was added to the Auto3DSeg milestone. I am having some trouble to understand how it relates to Auto3DSeg framework. Could you explain a bit? Thanks

@myron
Copy link
Copy Markdown
Collaborator Author

myron commented Oct 18, 2022

Hi @myron I saw this was added to the Auto3DSeg milestone. I am having some trouble to understand how it relates to Auto3DSeg framework. Could you explain a bit? Thanks

we used segresnet with deepsupervision, and this loss is to support deep supervision.

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Oct 19, 2022

/build

@wyli wyli enabled auto-merge (squash) October 19, 2022 10:59
@wyli wyli merged commit 8383f8b into Project-MONAI:dev Oct 19, 2022
@myron myron deleted the ds_loss branch October 22, 2022 18:50
wyli pushed a commit that referenced this pull request Oct 24, 2022
A small fix to followup on
#5338
to ensure  ds_loss returns a constant, not an array

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: myron <[email protected]>
wyli pushed a commit that referenced this pull request Oct 24, 2022
A small fix to followup on
#5338
to ensure  ds_loss returns a constant, not an array

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: myron <[email protected]>
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
A small fix to followup on
#5338
to ensure  ds_loss returns a constant, not an array

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: myron <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants