5284 Fixes release integration tests#5342
Merged
wyli merged 4 commits intoProject-MONAI:devfrom Oct 17, 2022
Merged
Conversation
wyli
changed the title
Nic-Ma
approved these changes
Oct 17, 2022
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
fixes-release-integration
branch
from
683b3d0 to
4d13552
Compare
Contributor
Author
|
/build |
wyli
added a commit
that referenced
this pull request
Oct 17, 2022
part of #5284 fixes incorrect ignite version used https://github.com/Project-MONAI/MONAI/actions/runs/3262265183 fixes autorunner test error: https://github.com/Project-MONAI/MONAI/actions/runs/3255478854/jobs/5347066136 fixes #5343 ### Description tests are fixed by upgrading dep version and moving `test_auto3dseg_autorunner` unit test to `test_integration_autorunner` integration test. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
bhashemian
pushed a commit
to JHancox/MONAI
that referenced
this pull request
Oct 20, 2022
part of Project-MONAI#5284 fixes incorrect ignite version used https://github.com/Project-MONAI/MONAI/actions/runs/3262265183 fixes autorunner test error: https://github.com/Project-MONAI/MONAI/actions/runs/3255478854/jobs/5347066136 fixes Project-MONAI#5343 ### Description tests are fixed by upgrading dep version and moving `test_auto3dseg_autorunner` unit test to `test_integration_autorunner` integration test. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: Behrooz <[email protected]>
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
part of #5284 fixes incorrect ignite version used https://github.com/Project-MONAI/MONAI/actions/runs/3262265183 fixes autorunner test error: https://github.com/Project-MONAI/MONAI/actions/runs/3255478854/jobs/5347066136 fixes #5343 ### Description tests are fixed by upgrading dep version and moving `test_auto3dseg_autorunner` unit test to `test_integration_autorunner` integration test. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: KumoLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #5284
fixes incorrect ignite version used https://github.com/Project-MONAI/MONAI/actions/runs/3262265183
fixes autorunner test error: https://github.com/Project-MONAI/MONAI/actions/runs/3255478854/jobs/5347066136
fixes #5343
Description
tests are fixed by upgrading dep version and moving
test_auto3dseg_autorunnerunit test totest_integration_autorunnerintegration test.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.