Skip to content

Dicece check for float target#5326

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
myron:dicece2
Oct 15, 2022
Merged

Dicece check for float target#5326
wyli merged 2 commits intoProject-MONAI:devfrom
myron:dicece2

Conversation

@myron
Copy link
Copy Markdown
Collaborator

@myron myron commented Oct 13, 2022

Fixes Project-MONAI/tutorials#987

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Oct 15, 2022

/build

@wyli wyli enabled auto-merge (squash) October 15, 2022 08:05
@wyli wyli merged commit da93c1b into Project-MONAI:dev Oct 15, 2022
wyli pushed a commit to wyli/MONAI that referenced this pull request Oct 15, 2022
Fixes Project-MONAI/tutorials#987



### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: myron <[email protected]>
bhashemian pushed a commit to JHancox/MONAI that referenced this pull request Oct 20, 2022
Fixes Project-MONAI/tutorials#987



### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: myron <[email protected]>
Signed-off-by: Behrooz <[email protected]>
@myron myron deleted the dicece2 branch October 22, 2022 18:50
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
Fixes Project-MONAI/tutorials#987



### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: myron <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test error: ./modules/TorchIO_MONAI_PyTorch_Lightning.ipynb

2 participants