Skip to content

5187 update the docstring of the is_pad parameter#5296

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
binliunls:5187-fix-flexibleunet-docstring
Oct 8, 2022
Merged

5187 update the docstring of the is_pad parameter#5296
wyli merged 2 commits intoProject-MONAI:devfrom
binliunls:5187-fix-flexibleunet-docstring

Conversation

@binliunls
Copy link
Copy Markdown
Contributor

Signed-off-by: binliu [email protected]

Fixes #5187 .

Description

Updated the docstring of the is_pad parameter in flexible-unet.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@binliunls binliunls changed the title update the docstring of the is_pad parameter 5187 update the docstring of the is_pad parameter Oct 8, 2022
@binliunls binliunls requested review from rijobro and wyli October 8, 2022 08:28
@binliunls
Copy link
Copy Markdown
Contributor Author

Hi @rijobro @wyli ,
I have updated the docstring of flexble-unet. Could you please help me review this update and tell me if the description of the "is_pad" parameter is ok for you?
Thanks,
Bin

@wyli wyli enabled auto-merge (squash) October 8, 2022 18:09
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Oct 8, 2022

/build

@wyli wyli merged commit 4082b35 into Project-MONAI:dev Oct 8, 2022
wyli pushed a commit that referenced this pull request Oct 10, 2022
Signed-off-by: binliu <[email protected]>

Fixes #5187 .

### Description

Updated the docstring of the is_pad parameter in flexible-unet.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: binliu <[email protected]>
@binliunls binliunls deleted the 5187-fix-flexibleunet-docstring branch October 21, 2022 13:31
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
Signed-off-by: binliu <[email protected]>

Fixes #5187 .

### Description

Updated the docstring of the is_pad parameter in flexible-unet.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: binliu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FlexibleUNet is_pad

2 participants