Upsample mode deconvgroup#5282
Merged
wyli merged 2 commits intoProject-MONAI:devfrom Oct 8, 2022
myron:upsample
Merged
Conversation
Signed-off-by: myron <[email protected]>
Contributor
|
Looks good to me, could you please update the docstring and add some test cases? |
Collaborator
Author
It already include all unit test cases in test_upsample_block.py since it iterates overall all options in UpsampleMode. And which docstring do I need to update? I'm not sure I understand what it means |
wyli
reviewed
Oct 7, 2022
Signed-off-by: myron <[email protected]>
wyli
approved these changes
Oct 8, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Contributor
|
/build |
wyli
pushed a commit
that referenced
this pull request
Oct 10, 2022
This adds an additional UpSample mode DECONVGROUP to upsample with groupwise convolution transpose. Unit tests are passed too. A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: myron <[email protected]>
myron
modified the milestones:
Auto3D Seg framework [P0 v1.0],
Auto3D Seg framework [internal ongoing milestone]
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
This adds an additional UpSample mode DECONVGROUP to upsample with groupwise convolution transpose. Unit tests are passed too. A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: myron <[email protected]> Signed-off-by: KumoLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an additional UpSample mode DECONVGROUP to upsample with groupwise convolution transpose.
Unit tests are passed too.
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.