Skip to content

4320 update docstrings for gradient based saliency#5268

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:4320-docstring-vis
Oct 5, 2022
Merged

4320 update docstrings for gradient based saliency#5268
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:4320-docstring-vis

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Oct 5, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #4320
it seems we also have sufficient modules to close #3542

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from ericspod and rijobro October 5, 2022 09:50
Signed-off-by: Wenqi Li <[email protected]>
Copy link
Copy Markdown
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Oct 5, 2022

/build

@wyli wyli enabled auto-merge (squash) October 5, 2022 10:38
@wyli wyli merged commit e4a0de9 into Project-MONAI:dev Oct 5, 2022
@wyli wyli deleted the 4320-docstring-vis branch October 5, 2022 11:42
wyli added a commit that referenced this pull request Oct 10, 2022
Signed-off-by: Wenqi Li <[email protected]>

Fixes #4320
it seems we also have sufficient modules to close #3542


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <[email protected]>
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
Signed-off-by: Wenqi Li <[email protected]>

Fixes #4320
it seems we also have sufficient modules to close #3542


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [x] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation missing for VanillaGrad etc interpretability. Guided back propogation (also combined with GradCAM)

2 participants